-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(html5): Added captionLocale property and related logic #20272
feat(html5): Added captionLocale property and related logic #20272
Conversation
...-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/users/SetUserCaptionLocaleMsgHdlr.scala
Outdated
Show resolved
Hide resolved
This pull request has conflicts ☹ |
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/db/CaptionLangDAO.scala
Outdated
Show resolved
Hide resolved
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/db/CaptionLangDAO.scala
Outdated
Show resolved
Hide resolved
akka-bbb-apps/src/main/scala/org/bigbluebutton/core/apps/caption/CaptionApp2x.scala
Show resolved
Hide resolved
This pull request has conflicts ☹ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only the backend code.
It looks good!
This pull request has conflicts ☹ |
Quality Gate passedIssues Measures |
Automated tests Summary✅ All the CI tests have passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
It adds the
captionLocale
property to the user table and also changes related logic, so now it is possible for the user to "speak" and produce captions in one language and read captions in another one.Motivation
So with the plugins, and the upcoming migration of the typed captions, this PR will not only enhance the usability for the plugin dev, but it will also give them the opportunity to develop a translation plugin in which instead of transcript what one is saying, they will translate it, even though their
speechLocale
is different from what they are receiving in the captions.