Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create meeting with multi presentations will set all of them to current #6122

Merged
merged 2 commits into from Oct 17, 2018

Conversation

zhu
Copy link
Contributor

@zhu zhu commented Sep 28, 2018

The system seems that can only process with only one current presentation.
But create meeting with multi pre-upload presentations will set all of them to current.

@ffdixon
Copy link
Member

ffdixon commented Sep 28, 2018

Thanks! Could you to send us a signed contributor agreement so we can review/merge in these fixes to BigBlueButton code base. See

http://docs.bigbluebutton.org/support/faq.html#contributing-to-bigbluebutton

@antobinary
Copy link
Member

Note resemblance to another PR still not merged #6043 1cef436

@ffdixon
Copy link
Member

ffdixon commented Oct 3, 2018

Thanks for signing the contributor agreement!

@GhaziTriki
Copy link
Member

GhaziTriki commented Oct 16, 2018

When I use this request body

<?xml version="1.0" encoding="UTF-8"?>
<modules><module name="presentation"><document url="https://placeholdit.imgix.net/~text?txtsize=96&amp;bg=30406B&amp;txtclr=ffffff&amp;txt=BigBlueButton&amp;w=800&amp;h=600"/></module></modules>

or

<?xml version="1.0" encoding="UTF-8"?>
<modules><module name="presentation"><document url="https://placeholdit.imgix.net/~text?txtsize=96&amp;bg=30406B&amp;txtclr=ffffff&amp;txt=BigBlueButton&amp;w=800&amp;h=600" filename="placeholder.png"/></module></modules>

I get the following error in logs

2018-10-16T16:42:37.849Z ERROR org.codehaus.groovy.grails.web.errors.GrailsExceptionResolver  - MissingMethodException occurred when processing request: [POST] /bigbluebutton/api/create
No signature of method: org.bigbluebutton.web.controllers.ApiController.downloadAndProcessDocument() is applicable for argument types: (java.lang.String, java.lang.String, java.lang.Boolean) values: [https://placeholdit.imgix.net/~text?txtsize=96&bg=30406B&txtclr=ffffff&txt=BigBlueButton&w=800&h=600, ...]
Possible solutions: downloadAndProcessDocument(), downloadAndProcessDocument(java.lang.Object, java.lang.Object, java.lang.Object, java.lang.Object). Stacktrace follows:
groovy.lang.MissingMethodException: No signature of method: org.bigbluebutton.web.controllers.ApiController.downloadAndProcessDocument() is applicable for argument types: (java.lang.String, java.lang.String, java.lang.Boolean) values: [https://placeholdit.imgix.net/~text?txtsize=96&bg=30406B&txtclr=ffffff&txt=BigBlueButton&w=800&h=600, ...]
Possible solutions: downloadAndProcessDocument(), downloadAndProcessDocument(java.lang.Object, java.lang.Object, java.lang.Object, java.lang.Object)
	at org.bigbluebutton.web.controllers.ApiController$_uploadDocuments_closure22$_closure135.doCall(ApiController.groovy:1858)
	at org.bigbluebutton.web.controllers.ApiController$_uploadDocuments_closure22.doCall(ApiController.groovy:1851)
	at org.bigbluebutton.web.controllers.ApiController.uploadDocuments(ApiController.groovy:1845)
	at org.bigbluebutton.web.controllers.ApiController$_closure3.doCall(ApiController.groovy:167)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

The fileName variable was ommited from this line https://github.com/bigbluebutton/bigbluebutton/pull/6122/files#diff-f4a6b2c8f478d1d26175b01acef414c5L1857

@zhu Could you please fix it?

@GhaziTriki GhaziTriki mentioned this pull request Oct 16, 2018
@ritzalam ritzalam merged commit 6eba10d into bigbluebutton:v2.0.x-release Oct 17, 2018
ritzalam added a commit that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants