Replace getMeetings call in health check with a isMeetingRunning call #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (for meetingID 0), to achieve the same check 'value' with a much lighter API call
farhatahmad
approved these changes
Jan 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the "BBB" part in the health check conducts a getMeetings API call towards the connected BBB/SL, which especially in the case of a large Scalelite deployment is a pretty heavy API call.
This PR replaces the getMeetings call with a isMeetingRunning call for the (arbitrary) meeting ID 0, which is much lighter, and in the case of SL, can be answered by simple Redis query.
It still answers the questions: 1) Is API responding and 2) is the secret/checksum correct, so has the same value in terms of a health check.