-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Scalelite Tagged Servers #5790
Open
Ithanil
wants to merge
20
commits into
bigbluebutton:master
Choose a base branch
from
Ithanil:tagged_servers
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac857ee
to
beedc4b
Compare
1ab2201
to
29c0c49
Compare
…pdown in room settings
…n GL: serverTag and serverTagRequired
…ide it entirely when the string is empty
…ropdown selection + tweaks&fixes
… config in sample.env
…s from the database (after changing the config)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds frontend support for "Tagged Servers" in Scalelite, a feature which is described here: blindsidenetworks/scalelite#1049
Description
This PR allows user to configure two new options for each room:
In terms of UI, it presents itself as seen in the following screenshots:
![Screenshot from 2024-04-29 15-48-45](https://private-user-images.githubusercontent.com/5860369/326461448-a1164666-fbac-45fa-a15c-32c55d0f3e71.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMzkxMDMsIm5iZiI6MTcxOTAzODgwMywicGF0aCI6Ii81ODYwMzY5LzMyNjQ2MTQ0OC1hMTE2NDY2Ni1mYmFjLTQ1ZmEtYTE1Yy0zMmM1NWQwZjNlNzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjJUMDY0NjQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDE4MmE1OWMxYWFjMDliYWNiYTQxZWE1NTAxZDQ2ZjNmNWQyNjI0MjVjN2I5YmY2OGQ2NzA0MTUwYWE0OTZiMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EO8ePR-e8TK5dnQFcarkJYYv4M-GppLU8wrdrnHI1qw)
![Screenshot from 2024-04-29 15-48-56](https://private-user-images.githubusercontent.com/5860369/326461441-d6ad5e0c-6a1c-431d-b7b0-b1207976bfcc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwMzkxMDMsIm5iZiI6MTcxOTAzODgwMywicGF0aCI6Ii81ODYwMzY5LzMyNjQ2MTQ0MS1kNmFkNWUwYy02YTFjLTQzMWQtYjdiMC1iMTIwNzk3NmJmY2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjJUMDY0NjQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWUyOWIxNTRhZGZmNDhhM2RlODBhMDljOGU5NzgwODYyZjYyMWY1Njk3ZDFiZjlkYWY2MTI4YWQ1ZGVjZjY5ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GLJ94HubyuJUQKIMJFq-MC4l4-rVkdW9U9a5OX7xKkg)
The list of available options is defined by the Greenlight administrator and certain tags can be restricted to certain role ids. In the current iteration of this feature, this is done via .env config file and is documented in
sample.env
:The required database migration is included and well tested. No RSpec tests have been added, but the feature is tested in deployment for multiple rooms, configuration combinations etc.
Notes
Currently, if a room has been configured with a tag and then later the tag is removed from the site-wide configuration or permission is revoked for the user's role, the room's configured tag will remain in the database and will still be used for create calls. However, the configuration field will show as empty in the UI and only allow changes to valid/allowed tags.Solved by commit 29c0c49What is "missing" / Future Development
Add a sync task for the administrator to remove invalid tags from rooms after configuration file changeDone (29c0c49)