GRN2-155: Begin preparing for removal of Twitter accounts #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhatahmad
reviewed
Jul 8, 2019
farhatahmad
reviewed
Jul 8, 2019
app/helpers/sessions_helper.rb
Outdated
| @@ -19,6 +19,24 @@ | |||
| module SessionsHelper | |||
| # Logs a user into GreenLight. | |||
| def login(user) | |||
| if !session["old_twitter_user_id"].nil? && user.provider != "twitter" | |||
| old_user = User.find(session["old_twitter_user_id"]) | |||
|
|
|||
There was a problem hiding this comment.
I would suggest moving this code into its own private method
shawn-higgins1
force-pushed
the
twitter_deprecation
branch
from
0778e6c
to
3198905
Compare
farhatahmad
approved these changes
Jul 9, 2019
jfederico
approved these changes
Jul 9, 2019
jfederico
approved these changes
Jul 9, 2019
balert
pushed a commit
to tubraunschweig/greenlight
that referenced
this pull request
Mar 31, 2020
…ton#615) * Add twitter deprecation message * Fix rspec test * Extract room switch to its own method * update method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.