GRN2-30: Add custom ldap sign in page #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-higgins1
force-pushed
the
custom-ldap-signin-page
branch
from
4fb9521
to
bcfec9d
Compare
jfederico
reviewed
Jul 9, 2019
| @@ -47,6 +47,8 @@ gem 'omniauth-google-oauth2' | |||
| gem 'omniauth-bn-office365', git: 'https://github.com/blindsidenetworks/omniauth-azure-ad.git' | |||
| gem 'omniauth-ldap' | |||
| gem 'omniauth-bn-launcher', '~> 0.1.0' | |||
| gem 'bn-ldap-authentication', git: 'https://github.com/blindsidenetworks/bn-ldap-authentication.git' | |||
| gem 'net-ldap' | |||
There was a problem hiding this comment.
@shawn-higgins1 do we need net-ldap as part of Greenlight? can it be part of the dependences declared in the gem itself?
Closed
balert
pushed a commit
to tubraunschweig/greenlight
that referenced
this pull request
Mar 31, 2020
* Add custom ldap signin page * Remove old omniauth-ldap gem * Use new bn gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.