fix: return empty on http error codes, log body. (#81)

bigboxer23 · Mar 22, 2024 · 040eb9d · 040eb9d
1 parent 9ee6304
commit 040eb9d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
 
   <groupId>com.bigboxer23</groupId>
   <artifactId>utils</artifactId>
-  <version>2.0.25</version>
+  <version>2.0.26</version>
 
   <name>utils</name>
   <!-- FIXME change it to the project's website -->

diff --git a/src/main/java/com/bigboxer23/utils/http/OkHttpUtil.java b/src/main/java/com/bigboxer23/utils/http/OkHttpUtil.java
@@ -165,6 +165,7 @@ public static <T> Optional<T> getBody(Response response, Class<T> clazz) {
 		}
 		if (!response.isSuccessful()) {
 			logger.error("request not successful body: " + body.get());
+			return Optional.empty();
 		}
 		try {
 			return Optional.ofNullable(getMoshi().adapter(clazz).fromJson(body.get()));