Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License inconsistency betweent the LICENSE file and the setup.cfg metadata #111

Closed
mattip opened this issue Jul 11, 2023 · 6 comments
Closed
Labels
fixed Fixed in last version

Comments

@mattip
Copy link

mattip commented Jul 11, 2023

The LICENSE says Apache2, the setup.cfg says GPL2. The underlying libheif is LGPL3. Found this by digging into the list of projects from this comment on numpy/numpy#24138. Did I read things right here?

@bigcat88
Copy link
Owner

bigcat88 commented Jul 11, 2023

x265 HEVC encoder has GPL2.
libheif as you say has LGPL3.
Sources of the pillow_heif is under Apache2.

GPL2 is license for binary wheels, as x265 binaries are in the wheels.

P.S.: I have a solution for that in mind, as latest libheif supports plugins, need to check idea on the musl based OS, if ok LICENSE will be Apache2(source)/LGPL3(wheels) for pillow_heif for next releases.

@mattip
Copy link
Author

mattip commented Jul 11, 2023

I think Apache2 and GPL2 are incompatible licenses, from the middle of https://www.apache.org/licenses/GPL-compatibility.html:

Despite our best efforts, the FSF has never considered the Apache License to be compatible with GPL version 2, citing the patent termination and indemnification provisions as restrictions not present in the older GPL license. The Apache Software Foundation believes that you should always try to obey the constraints expressed by the copyright holder when redistributing their work.

@bigcat88
Copy link
Owner

I will change the license to BSD 3-Clause from the next release.
Thank you for pointing it out.

@mattip
Copy link
Author

mattip commented Jul 11, 2023

👍 Thanks for providing this wrapper

@bigcat88 bigcat88 added the fixed in upcoming release fix will arrive with next release label Jul 19, 2023
@bigcat88 bigcat88 added fixed Fixed in last version and removed fixed in upcoming release fix will arrive with next release labels Aug 9, 2023
@bigcat88
Copy link
Owner

bigcat88 commented Aug 9, 2023

fixed in latest version.

@bigcat88 bigcat88 closed this as completed Aug 9, 2023
@mattip
Copy link
Author

mattip commented Aug 9, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in last version
Projects
None yet
Development

No branches or pull requests

2 participants