Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process get crashed with a corrupted file #79

Closed
bigcat88 opened this issue Feb 18, 2023 · 1 comment
Closed

Process get crashed with a corrupted file #79

bigcat88 opened this issue Feb 18, 2023 · 1 comment
Labels
bug Something isn't working fixed Fixed in last version

Comments

@bigcat88
Copy link
Owner

Based on this thread:

strukturag/libheif/issues/784

Tested it, and indeed it crashes the whole process.

Will try fix it in 0.10.0 upcoming release, will add additional check for image size after decoding.

@bigcat88 bigcat88 added bug Something isn't working fixed in upcoming release fix will arrive with next release labels Feb 18, 2023
@hackerfactor
Copy link

You should be able to replicate this crash by setting the ispe dimensions to be larger than the rendered dimensions. If the final output space is allocated based on the ispe dimensions, then you end up with a read overflow. (Read overflows are not great, but not too problematic.)

If the ispe dimensions are smaller than the rendered image, then -- depending on how you are copying the data -- it could result in a write-overflow. (Write overflows are bad, very bad.)

@bigcat88 bigcat88 added fixed Fixed in last version and removed fixed in upcoming release fix will arrive with next release labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Fixed in last version
Projects
None yet
Development

No branches or pull requests

2 participants