Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibHeif 1.17.0 support #156

Merged
merged 4 commits into from
Oct 24, 2023
Merged

LibHeif 1.17.0 support #156

merged 4 commits into from
Oct 24, 2023

Conversation

bigcat88
Copy link
Owner

@bigcat88 bigcat88 commented Oct 16, 2023

Fixes:

/home/runner/work/pillow_heif/pillow_heif/tests/numpy_test.py:24: in <module>
    im_heif.save(heif_buf)
/home/runner/work/pillow_heif/pillow_heif/pillow_heif/heif.py:341: in save
    _encode_images(self._images, fp, **kwargs)
/home/runner/work/pillow_heif/pillow_heif/pillow_heif/heif.py:554: in _encode_images
    ctx_write.save(fp)
/home/runner/work/pillow_heif/pillow_heif/pillow_heif/misc.py:370: in save
    data = self.ctx_write.finalize()
E   ValueError: heif_writer callback returned a null error text

This error happens with libheif 1.17.0

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Owner Author

o_O

@bigcat88
Copy link
Owner Author

Premultiplied alpha tests fails due to bug in new libheif: strukturag/libheif#993

@bigcat88 bigcat88 changed the title fixed "heif_writer callback returned a null error text" LibHeif 1.17.0 support Oct 17, 2023
@bigcat88
Copy link
Owner Author

NCLX profile test discussion lives here: Problem with saving NCLX profile

Good that from next version output_nclx_profile will be used that will fix a bug that I did not know even existed.

Anyway version 1.17.0 will be skipped(as it was with 1.15.0/1.16.0) and this PR will wait 1.17.1 version.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit c9f2e69 into master Oct 24, 2023
33 checks passed
@bigcat88 bigcat88 deleted the fix-libheif-1.17 branch October 24, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant