Linux: do not build libheif automatically from source
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 871 871
=========================================
Hits 871 871
|
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
added a commit
that referenced
this pull request
Nov 4, 2023
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
added a commit
that referenced
this pull request
Nov 4, 2023
* reverted some changes from #158 Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * restored checks for build from source Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent, because... There is no automatic building for macOS and Windows, so it is logical to remove it for Linux as well.
Versions starting from
0.10.0have no particular problems working with a fairly wide range of different libheif versions, and on Linux, assembling a libheif is not such a big problem.Also, starting from version
0.14.0, the minimum libheif version will be raised from1.12.0to1.16.1(or 1.16.2), because I really want to support correct image rotations and maintain image rotations normally.Also, the next step will be to add the ability to select an encoder, so that in the future it would be possible to try adding a hardware encoder from the
ffmpeg.Changes proposed in this pull request:
linux_build_libs.pydo not called automatically bysetup.pyInstallation