Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonym for chroma encoder parameter: subsampling #161

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

bigcat88
Copy link
Owner

@bigcat88 bigcat88 commented Nov 4, 2023

This will be useful for those who are used to specifying subsampling as in Pillow for JPEG.

If both parameters are present, chroma parameter takes precedence.

At first I wanted to remove the chroma parameter, but in libheif subsampling is called chroma, so I decided to do it the way I did, just add it as the synonym.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #161 (518d078) into master (b2bf274) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          871       875    +4     
=========================================
+ Hits           871       875    +4     
Files Coverage Δ
pillow_heif/misc.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit 5ac33e1 into master Nov 4, 2023
11 checks passed
@bigcat88 bigcat88 deleted the subsampling-parameter branch November 4, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant