Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing image_orientation value to libheif #168

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Conversation

bigcat88
Copy link
Owner

Changes concern only image encoding

Changes proposed in this pull request:

  • Removed rotation of image before encoding.
  • We add a parameter in the C module "image_orientation" that passes the orientation of the image to the libheif that should be recorded.

Orientation is taken from the same place(EXIF or XMP), so it should not be a big breaking change, in most(all?) cases results should be the same.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #168 (e77c4a0) into master (4614b8e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          874       881    +7     
=========================================
+ Hits           874       881    +7     
Files Coverage Δ
pillow_heif/as_plugin.py 100.00% <100.00%> (ø)
pillow_heif/heif.py 100.00% <100.00%> (ø)
pillow_heif/misc.py 100.00% <100.00%> (ø)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit 6ab4793 into master Nov 11, 2023
25 checks passed
@bigcat88 bigcat88 deleted the writing_orientation branch November 11, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant