New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for seed in generating keypair #487
Conversation
Hi @excerebrose --- See the comment I made on your related pull request in the cryptoconditions repository: bigchaindb/cryptoconditions#116 (comment) Some tests are failing. There was already a docs test that was failing and we hadn't gotten around to fixing; don't worry about that one. Besides that, we'll also have to get your cryptodonditions pull request merged first, then release a new version of the cryptoconditions package, then modify this pull request to use the new cryptoconditions package. That should fix the other failing tests. |
bigchaindb_driver/crypto.py
Outdated
"""Generates a cryptographic key pair. | ||
|
||
Args: | ||
seed (str) : Optional Seed, defaults to `None` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line of the docstring should be updated similar to the update suggested in bigchaindb/cryptoconditions#116 (comment)
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 5 5
Lines 235 235
=======================================
Hits 232 232
Misses 3 3 |
@excerebrose I updated |
@ttmc Fixed the docstring.you should be good to go |
Description
Adds support for seed in generating key pair as in the javascript driver, links to commit in the crypto conditions repository
Related PRs
Linked to change in cryptoconditions repo
Todos