refactor code & add test

bigchaindb · Jun 19, 2018 · 34c82a1 · 34c82a1
1 parent d812e64
commit 34c82a1
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 5 deletions.
diff --git a/src/connection.js b/src/connection.js
@@ -119,10 +119,7 @@ export default class Connection {
      * @param transaction
      */
     postTransaction(transaction) {
-        return this._req(this.getApiUrls('transactionsCommit'), {
-            method: 'POST',
-            jsonBody: transaction
-        })
+        return this.postTransactionCommit(transaction)
     }
 
     /**

diff --git a/test/connection/test_connection.js b/test/connection/test_connection.js
@@ -27,6 +27,9 @@ test('Generate API URLS', t => {
         'blocksDetail': 'blocks/%(blockHeight)s',
         'outputs': 'outputs',
         'transactions': 'transactions',
+        'transactionsSync': 'transactions?mode=sync',
+        'transactionsAsync': 'transactions?mode=async',
+        'transactionsCommit': 'transactions?mode=commit',
         'transactionsDetail': 'transactions/%(transactionId)s',
         'assets': 'assets',
     }

diff --git a/test/integration/test_integration.js b/test/integration/test_integration.js
@@ -35,7 +35,39 @@ test('Valid CREATE transaction', t => {
     )
     const txSigned = Transaction.signTransaction(tx, alice.privateKey)
 
-    return conn.postTransactionCommit(txSigned)
+    return conn.postTransaction(txSigned)
+        .then(resTx => t.truthy(resTx))
+})
+
+
+test('Valid CREATE transaction using async', t => {
+    const conn = new Connection(API_PATH)
+
+    const tx = Transaction.makeCreateTransaction(
+        asset(),
+        metaData,
+        [aliceOutput],
+        alice.publicKey
+    )
+    const txSigned = Transaction.signTransaction(tx, alice.privateKey)
+
+    return conn.postTransactionAsync(txSigned)
+        .then(resTx => t.truthy(resTx))
+})
+
+
+test('Valid CREATE transaction using sync', t => {
+    const conn = new Connection(API_PATH)
+
+    const tx = Transaction.makeCreateTransaction(
+        asset(),
+        metaData,
+        [aliceOutput],
+        alice.publicKey
+    )
+    const txSigned = Transaction.signTransaction(tx, alice.privateKey)
+
+    return conn.postTransactionSync(txSigned)
         .then(resTx => t.truthy(resTx))
 })