Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples for JS driver #142

Merged
merged 8 commits into from
May 11, 2018

Conversation

michielmulders
Copy link
Contributor

I created some examples based on the docs and added them to the js-driver.
I have code for websocket as well, but the stream doesn't seem to be working.
Gonna do some more tests on this, if it works, I'll add the code for websockets as well.

@codecov-io
Copy link

codecov-io commented Jan 20, 2018

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #142   +/-   ##
======================================
  Coverage    82.7%   82.7%           
======================================
  Files          11      11           
  Lines         266     266           
======================================
  Hits          220     220           
  Misses         46      46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c371e3b...c7b55e5. Read the comment docs.

**Seed/Keypair Functionality**: Create keypair with bip39 library.
-> `npm run seed-func`

## Notes
Copy link
Contributor

@future-is-present future-is-present Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather include this Notes part at the beginning, as otherwise the Different Examples do not work.

@michielmulders
Copy link
Contributor Author

@manolodewiner fixed the note to the top.

```
BIGCHAINDB_API_PATH=http://localhost:9984/api/v1/
BIGCHAINDB_APP_ID=<your-app-id>
BIGCHAINDB_APP_KEY=<your-app-key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are running BigchainDB in you own environment i.e. localhost, then app id and app key are not needed and should be null. Maybe is better if you use instead the reference to BigchainDB testnetwok

(
    "https://test.bigchaindb.com/api/v1/",
    {
        app_id: "Get one from testnet.bigchaindb.com",
        app_key: "Get one from testnet.bigchaindb.com"
    }
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think @michielmulders ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this

@future-is-present future-is-present merged commit b2d34c8 into bigchaindb:master May 11, 2018
@michielmulders michielmulders deleted the docs-examples branch May 17, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants