-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for JS driver #142
Examples for JS driver #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
======================================
Coverage 82.7% 82.7%
======================================
Files 11 11
Lines 266 266
======================================
Hits 220 220
Misses 46 46 Continue to review full report at Codecov.
|
examples/README.md
Outdated
**Seed/Keypair Functionality**: Create keypair with bip39 library. | ||
-> `npm run seed-func` | ||
|
||
## Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather include this Notes
part at the beginning, as otherwise the Different Examples
do not work.
@manolodewiner fixed the note to the top. |
``` | ||
BIGCHAINDB_API_PATH=http://localhost:9984/api/v1/ | ||
BIGCHAINDB_APP_ID=<your-app-id> | ||
BIGCHAINDB_APP_KEY=<your-app-key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are running BigchainDB in you own environment i.e. localhost, then app id and app key are not needed and should be null. Maybe is better if you use instead the reference to BigchainDB testnetwok
(
"https://test.bigchaindb.com/api/v1/",
{
app_id: "Get one from testnet.bigchaindb.com",
app_key: "Get one from testnet.bigchaindb.com"
}
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think @michielmulders ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this
I created some examples based on the docs and added them to the js-driver.
I have code for websocket as well, but the stream doesn't seem to be working.
Gonna do some more tests on this, if it works, I'll add the code for websockets as well.