Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

DEVDOCS-3540: [update] Catalog V3, change option_values to array #1259

Merged
merged 7 commits into from Apr 11, 2023

Conversation

slsriehl
Copy link
Collaborator

@slsriehl slsriehl commented Apr 7, 2023

DEVDOCS-3540

Change option_values to an array per @kamsar in #622.

Tested for the endpoints on which this schema appears:

  • /catalog/products/{product_id}/options and
  • /catalog/products/{product_id}/options/{option_id}

Both return an array.

@slsriehl
Copy link
Collaborator Author

slsriehl commented Apr 7, 2023

Waiting for clarity on 1131 and 1240.

@slsriehl
Copy link
Collaborator Author

Diff snapshots:

image

image

@slsriehl slsriehl marked this pull request as ready for review April 10, 2023 22:43
Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slsriehl slsriehl merged commit 08c50d5 into staging Apr 11, 2023
3 checks passed
@slsriehl slsriehl deleted the DEVDOCS-3540 branch April 11, 2023 16:53
@slsriehl slsriehl mentioned this pull request Apr 11, 2023
slsriehl added a commit that referenced this pull request Apr 11, 2023
DEVDOCS-3540: [update] Catalog V3, change option_values to array #1259
DEVDOCS-3395: [update] Pages V2, add deprecation callouts #1266
DEVDOCS-3396: [update] Catalog V3, mark url properties readOnly #1267
DEVDOCS-4853: [update] Email Templates, fix operating hours schema #1265
slsriehl added a commit that referenced this pull request Apr 13, 2023
Co-authored-by: Traci Porter <traci.porter@bigcommerce.com>
Co-authored-by: @kamsar
@slsriehl slsriehl mentioned this pull request Apr 13, 2023
bc-tgomez pushed a commit that referenced this pull request Apr 13, 2023
Co-authored-by: Traci Porter <traci.porter@bigcommerce.com>
Co-authored-by: @kamsar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants