Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

DEVDOCS-3540: Corrected product option value type from single to array #622

Closed
wants to merge 1 commit into from

Conversation

kamsar
Copy link

@kamsar kamsar commented Feb 16, 2022

The option_values property is declared as being a single object, but in reality the API returns an array of option values.

This PR corrects that.

@slsriehl
Copy link
Contributor

Thanks, @kamsar. We appreciate this & will look into getting it merged.

Internal: DEVDOCS-3540

@slsriehl slsriehl changed the base branch from master to DEVDOCS-3540 February 18, 2022 05:06
@S48-Mo
Copy link
Contributor

S48-Mo commented May 19, 2022

Hi, @kamsar @slsriehl can we expedite this one if possible please? We were going to make a PR for this bug had we not noticed it's been created already. It looks like once the merge conflict is resolved it's good to go.

@slsriehl
Copy link
Contributor

@S48-Mo & @kamsar -- I've pulled this into my sprint for next week.

@slsriehl
Copy link
Contributor

In the meantime, @kamsar, please pull upstream changes into your fork to update your master branch. Otherwise, we'll have to clone your fork to resolve this conflict. The ticket branch is up to date with our current master.

@slsriehl slsriehl changed the title Corrected product option value type from single to array DEVDOCS-3540: Corrected product option value type from single to array May 25, 2022
@slsriehl slsriehl self-assigned this May 25, 2022
@slsriehl slsriehl deleted the branch bigcommerce:DEVDOCS-3540 April 7, 2023 18:36
@slsriehl slsriehl closed this Apr 7, 2023
@slsriehl slsriehl reopened this Apr 7, 2023
@slsriehl slsriehl deleted the branch bigcommerce:DEVDOCS-3540 April 7, 2023 19:16
@slsriehl slsriehl closed this Apr 7, 2023
@slsriehl slsriehl reopened this Apr 7, 2023
slsriehl pushed a commit that referenced this pull request Apr 7, 2023
@slsriehl
Copy link
Contributor

slsriehl commented Apr 7, 2023

@kamsar This work accomplished in #1259 with credit to you. Thank you for contributing.

@slsriehl slsriehl closed this Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants