Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): select will now change input text if value changes #171

Merged
merged 2 commits into from
Aug 15, 2019
Merged

fix(component): select will now change input text if value changes #171

merged 2 commits into from
Aug 15, 2019

Conversation

jorgemoya
Copy link
Contributor

Component will now match the input text to the value selected, without having to click an option.

@jorgemoya jorgemoya requested a review from a team August 15, 2019 19:25
rtalvarez
rtalvarez approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@rtalvarez rtalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorgemoya jorgemoya merged commit 25facc6 into bigcommerce:master Aug 15, 2019
@jorgemoya jorgemoya deleted the fix-select-text branch August 15, 2019 19:43
amckemie pushed a commit to amckemie/big-design that referenced this pull request Sep 30, 2019
@jorgemoya
fix(component): select will now change input text if value changes (b…
98f54db 
…igcommerce#171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deini deini deini approved these changes

@rtalvarez rtalvarez rtalvarez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgemoya @deini @rtalvarez