feat(component): Add chip component #189
Conversation
(cherry picked from commit de4c480fb1dee5a6170dde3bde832fd3a5f9844d)
|
Hey @animesh1987 👋 pushed a commit with a couple of changes mainly:
|
| ></StyledCloseButton> | ||
| ); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Do we even want to render the chip if there is no label?
| return ( | |
| return label ? ( |
There was a problem hiding this comment.
If we add the above, you should add another test with no children.
There was a problem hiding this comment.
I thought about that but I think it's a bit easier to spot if we render a chip which looks wrong than to not render at all. Thoughts?
There was a problem hiding this comment.
Just from my own experience experimenting with chips, I think it's better if we display an empty chip than no chip at all. I was able to debug I wasn't sending the right text immediately.
|
|
||
| {renderDeleteButton()} | ||
| </StyledChip> | ||
| ); |
There was a problem hiding this comment.
Addition from above.
| ); | |
| ) : null; |
| export const StyledChip = styled(Box)` | ||
| align-items: center; | ||
| display: inline-flex; | ||
| user-select: none; |
There was a problem hiding this comment.
🍹Is there a specific reason why we wouldn't want people to select the text?
There was a problem hiding this comment.
Not really, it just looks terrible and doesn't seem that useful 🤔
| ></StyledCloseButton> | ||
| ); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Just from my own experience experimenting with chips, I think it's better if we display an empty chip than no chip at all. I was able to debug I wasn't sending the right text immediately.
|
Thanks for pushing it through @deini 👍 |
What
Testing
@jorgemoya