Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled components 6 bump poc #1335

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Conversation

leeBigCommerce
Copy link
Contributor

⚠️ Ongoing POC to see what it takes to bump Styled-Components to v6

What?

Describe what changes you are making. e.g. Adds X prop in the Box component.

Why?

Please provide the reason(s) why you are making this change? Please no one-liners like, It was missing.; expand upon the reason like, Adds X prop because it was missing in the Box component. Documentation notes this prop exists, but it actually wasn't implemented.

Screenshots/Screen Recordings

This is a component library so we love visually looking at changes! If this applies to your pull request, show us your hard work in action.

Testing/Proof

Explain how you tested your new feature or bugfix. Please refrain from one-liners like, Added tests.; expand upon how you tested your changes like, Added local tests to the new component and ensured test coverage was met. Manually tested on Safari@x.x.x..

@leeBigCommerce leeBigCommerce added the do not merge Don't merge this PR! label Jan 24, 2024
@leeBigCommerce leeBigCommerce force-pushed the styled-components-6-bump-poc branch 6 times, most recently from f88c62a to 40cd2e7 Compare February 6, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR!
Development

Successfully merging this pull request may close these issues.

None yet

1 participant