Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): add missing prop to open dropdown #463

Merged
merged 1 commit into from Oct 16, 2020
Merged

fix(component): add missing prop to open dropdown #463

merged 1 commit into from Oct 16, 2020

Conversation

jorgemoya
Copy link
Contributor

Dropdown's <List /> component was missing the isOpen prop.

Will lurk the Downshift library to figure out why getMenuProps returns any, which caused an oversight by me thinking ts would catch an issue like this.

@jorgemoya jorgemoya requested a review from a team October 16, 2020 15:57
@jorgemoya jorgemoya requested a review from a team as a code owner October 16, 2020 15:57
jorgemoya
jorgemoya commented Oct 16, 2020
View reviewed changes
packages/big-design/src/components/Select/Select.tsx
@@ -298,6 +298,7 @@ export const Select = typedMemo(
isOpen,
onOptionChange,
openMenu,
selectedOption,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed adding this dependency on #462

@jorgemoya jorgemoya merged commit 10b26a6 into bigcommerce:master Oct 16, 2020
@jorgemoya jorgemoya deleted the fix-dropdown branch October 16, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgemoya @chanceaclark