Bump min PHP to 7.0, start running tests on 7.1 and 7.2 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Plan is to follow up with actual fixes for 7.1 and 7.2. |
|
Given http://php.net/supported-versions.php, I'd say we should just drop support for 5.6 now and call it good. |
bookernath
force-pushed
the
bump-min-php-56
branch
2 times, most recently
from
b7f95e7
to
fba56e9
Compare
bookernath
changed the title
|
Updated to 7.0 @lord2800 |
|
7.0 passed, 7.1 and 7.2 have one failing test, follow-up PR will fix those. |
lord2800
approved these changes
Mar 21, 2018
bookernath
force-pushed
the
bump-min-php-56
branch
from
fba56e9
to
6800595
Compare
PHP 5.6 is the lowest supported version these days: http://php.net/supported-versions.php Therefore, I've updated readmes and other things to remove support for anything lower. I've also added 7.1 and 7.2 to Travis so we can start testing for compatibility with modern versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.0 is the lowest supported version these days: http://php.net/supported-versions.php
Therefore, I've updated readmes and other things to remove support for anything lower.
I've also added 7.1 and 7.2 to Travis so we can start testing for compatibility with modern versions.