Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix #220

Merged
merged 1 commit into from May 7, 2018
Merged

Typo fix #220

merged 1 commit into from May 7, 2018

Conversation

optomal7
Copy link
Contributor

@optomal7 optomal7 commented May 7, 2018

What?

I fixed a typo

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Attach images or add image links here.

Example Image

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.557% when pulling f7497b5 on optomal7:sku-update into ce672e6 on bigcommerce:master.

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage remained the same at 70.557% when pulling 8cc2dae on optomal7:sku-update into ce672e6 on bigcommerce:master.

@bookernath
Copy link
Contributor

@optomal7 thanks for your contribution! can you update this test as well?

->with($this->basePath . '/product/skus/1', (object)array());

@bookernath bookernath merged commit 3231829 into bigcommerce:master May 7, 2018
@lord2800
Copy link
Contributor

lord2800 commented May 7, 2018

@bookernath he's the new member of my team. 😄 Thanks for merging this though! I was about to get to it when I discovered you had already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants