Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests to GH actions #108

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Move tests to GH actions #108

merged 1 commit into from
Jul 7, 2022

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Jul 7, 2022 •
edited
Loading

Remove travis, use GH actions for testing instead.

@bookernath bookernath marked this pull request as ready for review July 7, 2022 16:15
@bookernath bookernath force-pushed the gh-actions-test branch 3 times, most recently from e48fb5b to 72151f3 Compare July 7, 2022 16:22
bc-chaz
bc-chaz reviewed Jul 7, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
matthewvolk
matthewvolk reviewed Jul 7, 2022
View reviewed changes
Copy link

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 Small nitpick, but we might want to update the README's second sentence from:

Tested with python 3.8

to

Tested with python 3.7, 3.8, 3.9

@bookernath
Copy link
Contributor Author

@matthewvolk updated the readme, thanks.

@bookernath bookernath changed the title (wip) Move tests to GH actions Move tests to GH actions Jul 7, 2022
bc-chaz
bc-chaz reviewed Jul 7, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
bc-chaz
bc-chaz reviewed Jul 7, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
bc-chaz
bc-chaz approved these changes Jul 7, 2022
View reviewed changes
Copy link

@bc-chaz bc-chaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bookernath bookernath merged commit 092c989 into bigcommerce:master Jul 7, 2022
@bookernath bookernath deleted the gh-actions-test branch July 7, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewvolk matthewvolk matthewvolk left review comments

@bc-chaz bc-chaz bc-chaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bookernath @matthewvolk @bc-chaz