Allow ListableApiSubResource to not require an id #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookernath
force-pushed
the
master
branch
2 times, most recently
from
4419138
to
69472e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a use case that isn't covered by ProductSkus.all(). Namely the ability to search for a product_option sku. According to the Search a product by SKU section on the curl quickstart, you can search for a sku via /api/v2/products/skus?sku=. This functionality was required to find which product an option sku belonged to. Or at least I couldn't find a better way to search for it.
ProductSkus didn't allow for this type of searching since the productid was mandatory. I altered the _get_all_path method to return an alternate path based on if an id was found or not.
This may not be the best place for this fix since I'm not sure if other ListableApiSubResources will work in this manner with out the parentid.
Thanks for taking a look.