Skip to content

Commit

Permalink
fix(storefront): BCTHEME-268 Update carousel images to improve LCP in…
Browse files Browse the repository at this point in the history
…dicator from Lighthouse performance report (#1876)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
  • Loading branch information
yurytut1993 and BC-tymurbiedukhin committed Oct 21, 2020
1 parent 2c0aa37 commit 13a0058
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Update carousel images to improve LCP indicator from Lighthouse performance report. [#1876](https://github.com/bigcommerce/cornerstone/pull/1876)
- Add aria label with price to Product Grid Item. [#1875](https://github.com/bigcommerce/cornerstone/pull/1875)
- Search result not notified by screen reader. [#1867](https://github.com/bigcommerce/cornerstone/pull/1867)
- Add aria label with price to Product List Item. [#1878](https://github.com/bigcommerce/cornerstone/pull/1878)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,17 @@
margin-bottom: (spacing("double") + spacing("single"));
margin-top: -(spacing("single")); // 3
overflow: hidden;
visibility: hidden;
opacity: 0;

&.is-visible {
visibility: visible;
opacity: 1;
}

@include breakpoint("medium") {
margin-top: -(spacing("single") + spacing("base")); // 3
}

&.slick-initialized {
opacity: 1;
max-height: 100vh;

@include breakpoint("small") {
Expand Down

0 comments on commit 13a0058

Please sign in to comment.