fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs (#1779)

bigcommerce · Aug 26, 2020 · 4f0e081 · 4f0e081
1 parent 2e260eb
commit 4f0e081
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Fixed improper heading hierarchy on PLPs. [#1779](https://github.com/bigcommerce/cornerstone/pull/1779)
 - Cornerstone - Cart link not visible on mobile Chrome depending on swatch image size. [#1793](https://github.com/bigcommerce/cornerstone/pull/1793)
 - Added a valid ARIA role for li elemenents on "Related Products" tab [#1782](https://github.com/bigcommerce/cornerstone/pull/1782)
 - Fixed IDs used in ARIA and labels which are not unique. [#1791](https://github.com/bigcommerce/cornerstone/pull/1791)

diff --git a/assets/scss/components/foundation/accordion/_accordion.scss b/assets/scss/components/foundation/accordion/_accordion.scss
@@ -21,6 +21,7 @@
 }
 
 .accordion-title {
+    font-size: remCalc(15px);
     margin: 0;
 }
 

diff --git a/assets/scss/layouts/sidebar/_block.scss b/assets/scss/layouts/sidebar/_block.scss
@@ -16,6 +16,7 @@
 }
 
 .sidebarBlock-heading {
+    font-size: remCalc(15px);
     margin-top: 0;
     text-transform: inherit;
 }
diff --git a/templates/components/category/shop-by-price.html b/templates/components/category/shop-by-price.html
@@ -1,6 +1,6 @@
 {{#and theme_settings.shop_by_price_visibility shop_by_price}}
     <div class="sidebarBlock">
-        <h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
+        <h2 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h2>
         <ul class="navList">
             {{#each shop_by_price}}
             <li class="navList-item">

diff --git a/templates/components/category/sidebar.html b/templates/components/category/sidebar.html
@@ -1,7 +1,7 @@
 <nav>
     {{#if category.subcategories}}
         <div class="sidebarBlock">
-            <h5 class="sidebarBlock-heading">{{category.name}}</h5>
+            <h2 class="sidebarBlock-heading">{{category.name}}</h2>
             <ul class="navList">
                 {{#each category.subcategories}}
                 <li class="navList-item">

diff --git a/templates/components/faceted-search/selected-facets.html b/templates/components/faceted-search/selected-facets.html
@@ -1,7 +1,7 @@
 <div class="facetedSearch-refineFilters sidebarBlock">
-    <h5 class="sidebarBlock-heading">
+    <h2 class="sidebarBlock-heading">
         {{lang 'search.faceted.selected.title'}}
-    </h5>
+    </h2>
 
     {{#if items}}
         <ul class="inlineList inlineList--labels">