Skip to content

Commit

Permalink
fix(storefront): BCTHEME-385 move a phrase from html to en.json (#1972)
Browse files Browse the repository at this point in the history
  • Loading branch information
bc-alexsaiannyi committed Feb 2, 2021
1 parent ad5c3f1 commit 799b570
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Moved phrase from compare.html to en.json for increasing localization. [#1972](https://github.com/bigcommerce/cornerstone/pull/1972)
- Fixed focus for sort by dropdown on reloading page. [#1964](https://github.com/bigcommerce/cornerstone/pull/1964)
- Fixed filtered selection not announced by screen reader. [#1966](https://github.com/bigcommerce/cornerstone/pull/1966)

Expand Down
1 change: 1 addition & 0 deletions lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,7 @@
"5": "5 stars (best)"
},
"write_a_review": "Write a Review",
"no_reviews": "No Reviews",
"form_write": {
"name": "Name",
"email": "Email",
Expand Down
2 changes: 1 addition & 1 deletion templates/pages/compare.html
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ <h3 class="card-title">
{{#if rating}}
{{> components/products/ratings rating=rating}}
{{else}}
No Reviews
{{lang 'products.reviews.no_reviews'}}
{{/if}}
</td>
{{/each}}
Expand Down

0 comments on commit 799b570

Please sign in to comment.