BCTHEME-160: add valid ARIA role for Related Products tab

bigcommerce · Aug 12, 2020 · 863ac8e · 863ac8e
1 parent 353c9c8
commit 863ac8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Added a valid ARIA role for li elemenents on "Related Products" tab [#1782](https://github.com/bigcommerce/cornerstone/pull/1782)
 
 ## 4.9.0 (08-05-2020)
 

diff --git a/templates/components/products/tabs.html b/templates/components/products/tabs.html
@@ -1,11 +1,11 @@
 <ul class="tabs" data-tab role="tablist">
     {{#if product.related_products}}
-        <li class="tab is-active" role="presentational">
+        <li class="tab is-active" role="presentation">
             <a class="tab-title" href="#tab-related" role="tab" tabindex="0" aria-selected="true" controls="tab-related">{{lang 'products.related_products'}}</a>
         </li>
     {{/if}}
     {{#if product.similar_by_views}}
-        <li class="tab{{#unless product.related_products}} is-active{{/unless}}" role="presentational">
+        <li class="tab{{#unless product.related_products}} is-active{{/unless}}" role="presentation">
             <a class="tab-title" href="#tab-similar" role="tab" tabindex="0" aria-selected="{{#if product.related_products}}false{{else}}true{{/if}}" controls="tab-similar">{{lang 'products.similar_by_views'}}</a>
         </li>
     {{/if}}