fix(storefront): BCTHEME-161 ARIA attributes on Write Review modal ne…

…ed valid values
bigcommerce · Aug 21, 2020 · 8df4ccb · 8df4ccb
1 parent 353c9c8
commit 8df4ccb
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/templates/components/products/modals/writeReview.html b/templates/components/products/modals/writeReview.html
@@ -30,7 +30,7 @@ <h5 class="product-title">{{ product.title }}</h5>
                     </label>
                     <!-- Stars -->
                     <!-- TODO: Review Stars need to be componentised, both for display and input -->
-                    <select id="rating-rate" class="form-select" name="revrating">
+                    <select id="rating-rate" class="form-select" name="revrating" aria-required="true">
                         <option value="">{{lang 'products.reviews.select_rating'}}</option>
                         {{#for 1 5}}
                             {{#if ../product.reviews.selected_rating '===' $index}}
@@ -44,17 +44,17 @@ <h5 class="product-title">{{ product.title }}</h5>
 
                 <!-- Name -->
                 {{#if product.reviews.author}}
-                    {{> components/common/forms/text id="revfromname" name="revfromname" label=(lang 'products.reviews.form_write.name') value=product.reviews.author}}
+                    {{> components/common/forms/text id="revfromname" name="revfromname" required="true" label=(lang 'products.reviews.form_write.name') value=product.reviews.author}}
                 {{else}}
-                    {{> components/common/forms/text id="revfromname" name="revfromname" label=(lang 'products.reviews.form_write.name') value=customer.name}}
+                    {{> components/common/forms/text id="revfromname" name="revfromname" required="true" label=(lang 'products.reviews.form_write.name') value=customer.name}}
                 {{/if}}
 
                 {{#if product.reviews.show_review_email}}
                     <!-- Email -->
                     {{#if product.reviews.email}}
-                        {{> components/common/forms/text id="email" name="email" required="false" label=(lang 'products.reviews.form_write.email') value=product.reviews.email}}
+                        {{> components/common/forms/text id="email" name="email" required="true" label=(lang 'products.reviews.form_write.email') value=product.reviews.email}}
                     {{else}}
-                        {{> components/common/forms/text id="email" name="email" required="false" label=(lang 'products.reviews.form_write.email') value=customer.email}}
+                        {{> components/common/forms/text id="email" name="email" required="true" label=(lang 'products.reviews.form_write.email') value=customer.email}}
                     {{/if}}
                 {{/if}}