Skip to content

Commit

Permalink
Remove remote_api_scripts from the templates
Browse files Browse the repository at this point in the history
This should avoid double inclusion of some of the analytics code. (eg. facebook pixel)
  • Loading branch information
icatalina committed May 22, 2019
1 parent 347e8cf commit b0ac27b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Draft
- Fix to PDP Product Reviews Link Not Clickable. [#1498](https://github.com/bigcommerce/cornerstone/pull/1498)
- Update jQuery to 3.4.1 [#1502](https://github.com/bigcommerce/cornerstone/pull/1502)
- Remove remote_api_scripts to avoid double firing analytics [#1505](https://github.com/bigcommerce/cornerstone/pull/1505)

## 3.4.3 (2019-05-10)
- Fix to open Bulk Pricing modal from Quick View. [#1483](https://github.com/bigcommerce/cornerstone/pull/1483)
Expand Down
1 change: 0 additions & 1 deletion templates/components/cart/content.html
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,3 @@ <h4 class="cart-item-name"><a href="{{url}}">{{name}}</a></h4>
{{/each}}
</tbody>
</table>
{{{ remote_api_scripts }}}
1 change: 0 additions & 1 deletion templates/pages/cart.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
{{/if}}
{{else}}
<h3>{{lang 'cart.checkout.empty_cart'}}</h3>
{{{ remote_api_scripts }}}
{{/if}}

</main>
Expand Down

0 comments on commit b0ac27b

Please sign in to comment.