fix(storefront): BCTHEME-431 remove horizontal scroll on swatch optio…

…ns PDP
bigcommerce · Mar 29, 2021 · bdc9e88 · bdc9e88
1 parent 437f0cc
commit bdc9e88
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Fixed unnecessary horizontal scroll on swatch options on PDP. [#2023](https://github.com/bigcommerce/cornerstone/pull/2023)
 
 ## 5.3.0 (03-24-2021)
 - IE11 - Clicking on Search Does Not Display Search Bar. [#2017](https://github.com/bigcommerce/cornerstone/pull/2017)

diff --git a/assets/js/theme/common/product-details.js b/assets/js/theme/common/product-details.js
@@ -25,6 +25,21 @@ export default class ProductDetails extends ProductDetailsBase {
         const hasOptions = $productOptionsElement.html().trim().length;
         const hasDefaultOptions = $productOptionsElement.find('[data-default]').length;
         const $productSwatchGroup = $('[id*="attribute_swatch"]', $form);
+        const $productSwatchLabels = $('.form-option-swatch', $form);
+
+        $(window).on('load', () => {
+            $.each($productSwatchLabels, (_, label) => {
+                const $optionImage = $('.form-option-expanded', $(label));
+                const optionImageWidth = $optionImage.outerWidth();
+                const { right } = label.getBoundingClientRect();
+                const emptySpaceToScreenRightBorder = window.screen.width - right;
+                const shiftValue = optionImageWidth - emptySpaceToScreenRightBorder;
+
+                if (emptySpaceToScreenRightBorder < (optionImageWidth + 55)) {
+                    $optionImage.css('left', `${shiftValue > 0 ? -shiftValue : shiftValue}px`);
+                }
+            });
+        });
 
         if (context.showSwatchNames) {
             this.$swatchOptionMessage.removeClass('u-hidden');