Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3508 #1017

Merged
merged 1 commit into from
Jun 7, 2017
Merged

STENCIL-3508 #1017

merged 1 commit into from
Jun 7, 2017

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Jun 7, 2017

Summary

Swaps 'writeReview' for 'write_review' so that the link in email works and the fix for #984 remains in place.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

http://recordit.co/kKCS6DCywV

Attach images or add image links here.

Fix

cc @bigcommerce/stencil-team @bookernath

@willfaught
Copy link

Can you add a summary to the commit message?

@willfaught
Copy link

And the PR. :)

@willfaught
Copy link

You seem to have used write_review, not write-review. Is that intended?

@willfaught
Copy link

Can you point to where write_review/write-review are used in the HTML?

Copy link
Contributor

@mcampa mcampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line to the changelog

@mjschock
Copy link
Contributor Author

mjschock commented Jun 7, 2017

@willfaught - the write_review link is included in the html of the product review emails. in the GIF attached, you'll see it in the url. the product.js knows to open the modal when that is in the url.

@mjschock mjschock merged commit a5069ba into bigcommerce:master Jun 7, 2017
@mjschock mjschock deleted the STENCIL-3508 branch June 7, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants