-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore product image carousel #1024
Restore product image carousel #1024
Conversation
@bigcommerce/stencil-team |
<ul class="productView-thumbnails" data-slick='{ | ||
"infinite": false, | ||
"mobileFirst": true, | ||
"slidesToShow": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should limit to just 4 when we have the count from product.images
@sacr3dc0w how does it affect product pages which have more than 6 images. Lets say 10 images ? Can you provide a screenshot for that. Also how does it affect other screen sizes like tablet or mobile? |
@junedkazi Since the width for
For products that have more than 5 images, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! One question. Is it possible to customise the colour of the arrows? We need to make sure the arrows are visible on a dark background (i.e.: bold theme). Can you please confirm? Thanks!
I decoded the Data URI SVG's for the
In doing so, we're able to fill the stroke of the SVG using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work man 👍
What?
Cornerstone lacks an image carousel for product images. This restores that functionality. Slick needs to be triggered on opening modal window for QuickView.
Screenshots