STENCIL-3533 Remove gift certificate format validation #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we had a Gift Certificates API for the creation or import of gift certificates from another system, gift certificates in BC were all of a single format, alphanumeric with hyphens like this: AAA-AAA-AAA-AAA However, now we have the API and 3rd parties are welcome to import certificates of an arbitrary format. However, Cornerstone still validates the old format, which will cause these imported certificates to fail.Making this change to fix that and allow any format.
junedkazi
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Before we had a Gift Certificates API for the creation or import of gift certificates from another system, gift certificates in BC were all of a single format, alphanumeric with hyphens like this:
AAA-AAA-AAA-AAA
However, now we have the API and 3rd parties are welcome to import certificates of an arbitrary format.
However, Cornerstone still validates the old format, which will cause these imported certificates to fail. Making this change to fix that and allow any format.
Tickets / Documentation
Screenshots (if appropriate)