Toggle displaying product description/warranty in tab format #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sacr3dc0w Thanks for the PR! I need to get someone from our design team to take a look at this and then we can do code review. |
mcampa
reviewed
Jun 23, 2017
config.json
Outdated
| @@ -67,6 +67,7 @@ | |||
| "show_accept_mastercard": false, | |||
| "show_accept_paypal": false, | |||
| "show_accept_visa": false, | |||
| "product_details_tabs": true, | |||
There was a problem hiding this comment.
Can you rename this to show_product_details_tabs?
|
Looking good. Please rebase and fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the multiple PR. Struggling to figure out what I broke when merging branches/squashing commits.
What?
Allow the ability to disable displaying product descriptions in tabbed containers.
Screenshots (if appropriate)