STENCIL-3592 - Fix H1-H6 font-sizing #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shanth100 here's a bundle with the changes: |
mjschock
changed the title
|
@shanth100 here's the latest bundle which includes fixes for h1-h6, although some of these heading's are overridden by more specific styles, for example |
junedkazi
approved these changes
Jul 5, 2017
|
I have tested this yesterday and it looked good to me. However in the release there were some errors. So, I will wait for further instructions from Michael. If those failures don't matter I can give a thumbs up: https://launchbay.bigcommerce.net/projects/1/releases/35406 |
|
Need to make some test changes as the "name" attributes changed and an error message change. But this LGTM 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug that showed up in Theme Editor where changing the H1 font size affected H2's because the same style (using the H1 font size) was being applied to both types of heading.
Tickets / Documentation
Add links to any relevant tickets and documentation.
cc @bigcommerce/stencil-team @shanth100