Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce theme bundle size by using minified libraries #1039

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Reduce theme bundle size by using minified libraries #1039

merged 1 commit into from
Jul 20, 2017

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jul 7, 2017 •
edited
Loading

What?

In additional effort to #1037/#1038 and reduce the size of the theme bundle, I've pointed async, jquery-zoom, and pace to their minified versions.

Screenshots

before
1_before

after
2_after

mcampa
mcampa approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@mcampa mcampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

41KB less, not bad

@junedkazi
Copy link
Contributor

@sacr3dc0w can you please rebase.

@sacr3dc0w
Copy link
Contributor Author

sacr3dc0w commented Jul 19, 2017 •
edited
Loading

@mcampa ~89KB less if you factor in #1037

@mjschock
Copy link
Contributor

@sacr3dc0w - just needs a rebase

@mjschock mjschock merged commit d9a05d8 into bigcommerce:master Jul 20, 2017
@sacr3dc0w sacr3dc0w deleted the theme-bundle branch July 20, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcampa mcampa mcampa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sacr3dc0w @junedkazi @mjschock @mcampa @PreciselyAlyss