Move some validation messages to lang file #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bookernath
approved these changes
Jul 9, 2017
junedkazi
reviewed
Jul 18, 2017
CHANGELOG.md
Outdated
| @@ -6,7 +6,8 @@ | |||
| - Add on/off toggle to the theme editor for the "Shop by Price" panel located on category pages [#1036](https://github.com/bigcommerce/cornerstone/pull/1036) | |||
| - Fix H1-H6 font-sizing [#1034](https://github.com/bigcommerce/cornerstone/pull/1034) | |||
| - Reduce theme bundle size by using specific minified libraries [#1037](https://github.com/bigcommerce/cornerstone/pull/1037) | |||
| - Fix google plus spacing issue [#1041](https://github.com/bigcommerce/cornerstone/pull/1041) | |||
| - Fix google plus spacing issue [#1041](https://github.com/bigcommerce/cornerstone/pull/1041) | |||
| - Move some hard-coded validation messages to language file [#1040](https://github.com/bigcommerce/cornerstone/pull/1040) | |||
There was a problem hiding this comment.
Can you please rebase & put this change log under draft.
junedkazi
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move some hard-coded validation messages over to the language file