Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global Sass variables to easily toggle exposure of Foundation styles from Citadel #1047

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Add global Sass variables to easily toggle exposure of Foundation styles from Citadel #1047

merged 1 commit into from
Jul 21, 2017

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Jul 20, 2017

What?

  • Adds global sass $include-html-classes variable for easy exposure of Foundation styles from Citadel. Simply set $include-html-classes to true.

Screenshots (if appropriate)

  • before scenario: i try to include some basic Foundation 5 styles such as grid and panel:
<div class="body">
    {{#block "hero"}} {{/block}}
    <div class="container">
        {{#block "page"}} {{/block}}
    </div>
    {{> components/common/modal}}

    <div class="row">
        <div class="small-2 columns">2 columns</div>
        <div class="small-10 columns">10 columns</div>
    </div>
    <div class="row">
        <div class="small-3 columns">3 columns</div>
        <div class="small-9 columns">9 columns</div>
    </div>

    <div class="panel callout radius">
        <h5>This is a callout panel.</h5>
        <p>It's a little ostentatious, but useful for important content.</p>
    </div>
</div>

and they don't show up:

-- i can't add screenshots right now --

  • after setting $include-html-classes to true, they show up:

-- i can't add screenshots right now --

cc @bigcommerce/stencil-team

Copy link
Contributor

@davidchin davidchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these changes! I'm happy with this solution 👍

@mjschock mjschock changed the title Expose $include-html-classes flag to expose Foundation styles Add global Sass variables to easily toggle exposure of Foundation styles from Citadel Jul 20, 2017
@mjschock mjschock merged commit ee16e42 into bigcommerce:master Jul 21, 2017
@mjschock mjschock deleted the foundationIncludeHtmlClassesFlag branch July 21, 2017 22:01
@SrckyD
Copy link

SrckyD commented Jul 15, 2022

It would have been nice that you guys have documented this somewhere (even after 5 years) instead of having devs search for this solution on the internet and wasting time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants