Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-2922 Change Cornerstone to use "page_type" instead of "template_file" #1050

Merged
merged 5 commits into from
Jul 24, 2017

Conversation

mcampa
Copy link
Contributor

@mcampa mcampa commented Jul 24, 2017

What?

This change the use of template for page_type.

Address the issue with javascript not running for custom template pages

Tickets / Documentation

https://jira.bigcommerce.com/browse/STENCIL-2922

I programmatically generated the map between templates and page types.

pages/account/orders/all -> account_orderstatus
pages/account/orders/details -> account_order
pages/account/addresses -> account_addressbook
pages/account/add-address -> shippingaddressform
pages/account/add-return -> account_new_return
pages/account/add-wishlist -> add-wishlist
pages/account/recent-items -> account_recentitems
pages/account/download-item -> account_downloaditem
pages/account/edit -> editaccount
pages/account/inbox -> account_inbox
pages/account/return-saved -> account_saved_return
pages/account/returns -> account_returns
pages/auth/login -> login
pages/auth/account-created -> createaccount_thanks
pages/auth/create-account -> createaccount
pages/auth/new-password -> getnewpassword
pages/auth/forgot-password -> forgotpassword
pages/blog -> blog
pages/blog-post -> blog_post
pages/brand -> brand
pages/brands -> brands
pages/cart -> cart
pages/category -> category
pages/compare -> compare
pages/contact-us -> page_contact_form
pages/errors -> 
pages/errors/404 -> 404
pages/gift-certificate/purchase -> giftcertificates
pages/gift-certificate/balance -> giftcertificates_balance
pages/gift-certificate/redeem -> giftcertificates_redeem
pages/home -> default
pages/order-complete -> 
pages/page -> page
pages/product -> product
pages/amp/product-options -> amp_product_options
pages/search -> search
pages/rss -> rss
pages/sitemap -> sitemap
pages/subscribed -> newsletter_subscribe
pages/account/wishlist-details -> wishlist
pages/account/wishlists -> wishlists

@bigcommerce/stencil-team

Copy link
Contributor

@mjschock mjschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs integration testing

'pages/gift-certificate/balance': () => import('./theme/gift-certificate'),
'pages/gift-certificate/redeem': () => import('./theme/gift-certificate'),
'pages/home': () => import('./theme/home'),
'pages/order-complete': () => import('./theme/order-complete'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice that this line is removed completely. Is this intentional ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that page does not exist in stencil. I'll remove theme/order-complete.js

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also https://github.com/bigcommerce/cornerstone/blob/master/templates/pages/order-complete.html

@mcampa mcampa merged commit 89bc16b into bigcommerce:master Jul 24, 2017
@mcampa mcampa deleted the page_type-fix branch July 24, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants