-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STENCIL-2922 Change Cornerstone to use "page_type" instead of "template_file" #1050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just needs integration testing
'pages/gift-certificate/balance': () => import('./theme/gift-certificate'), | ||
'pages/gift-certificate/redeem': () => import('./theme/gift-certificate'), | ||
'pages/home': () => import('./theme/home'), | ||
'pages/order-complete': () => import('./theme/order-complete'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did notice that this line is removed completely. Is this intentional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that page does not exist in stencil. I'll remove theme/order-complete.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also https://github.com/bigcommerce/cornerstone/blob/master/templates/pages/order-complete.html
What?
This change the use of
template
forpage_type
.Address the issue with javascript not running for custom template pages
Tickets / Documentation
https://jira.bigcommerce.com/browse/STENCIL-2922
I programmatically generated the map between templates and page types.
@bigcommerce/stencil-team