STENCIL-3559 403 error message #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
reviewed
Aug 1, 2017
lang/en.json
Outdated
| "message": "You do not have permission to access this page." | ||
| "page_heading": "Sorry! Please log in to continue", | ||
| "message": "You do not have permission to access this page. If you were logged in, ", | ||
| "sign_in": "please sign in" |
There was a problem hiding this comment.
If you were logged in, please sign in does not make sense to me. Is this the actual copy or this is going to change ?
There was a problem hiding this comment.
Sorry! Please log in to continue
If you were logged in, please log back in
to resume your work in a new session.
There was a problem hiding this comment.
So I think it is missing to resume your work in a new session. ?
junedkazi
approved these changes
Aug 1, 2017
|
|
mcampa
force-pushed
the
STENCIL-3559-403
branch
from
65845c5
to
e59a50b
Compare
junedkazi
approved these changes
Aug 2, 2017
There was a problem hiding this comment.
@nickdengler just a heads up this might break tests which are validating 403 along with the content.
|
Thanks, I have a PR ready with the fix for this. When this goes out, we'll need to merge it at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the 403 page message to be more friendly
https://jira.bigcommerce.com/browse/STENCIL-3559
before
after
@bigcommerce/stencil-team