STENCIL-3383 Do not show add to cart on disabled products. #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
force-pushed
the
STENCIL-3383-list-view
branch
from
51eb385
to
9e5de44
Compare
|
💚 |
mcampa
reviewed
Aug 14, 2017
| @@ -43,7 +43,7 @@ | |||
| <a href="{{url}}" class="button button--small card-figcaption-button" data-product-id="{{id}}">{{lang 'products.choose_options'}}</a> | |||
| {{/if}} | |||
| {{#if pre_order}} | |||
| <a href="{{url}}" class="button button--small card-figcaption-button">{{lang 'products.pre_order'}}</a> | |||
| <a href="{{pre_order_add_to_cart_url}}" class="button button--small card-figcaption-button">{{lang 'products.pre_order'}}</a> | |||
There was a problem hiding this comment.
yes it will be a new fields which will only be passed for pre-order. On product details page it is a form so it is not required on those pages. But on pages where it is a card it is necessary bcoz earlier it was taking users to product detail pages. It is a similar url construct to add to cart.
mjschock
approved these changes
Aug 14, 2017
junedkazi
force-pushed
the
STENCIL-3383-list-view
branch
from
751634b
to
f55b397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a couple of things;
Tickets / Documentation
https://jira.bigcommerce.com/browse/STENCIL-3383
https://jira.bigcommerce.com/browse/STENCIL-3353
Screenshots (if appropriate)
Before
After
Pre order
options
disabled online ordering
Add to cart
Login for pricing in list view
@bigcommerce/stencil-team @bc-ranji @cristycarpenter