Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECKOUT-2461 Style optimized checkout checklist radios buttons #1088

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

icatalina
Copy link
Contributor

What?

Styling of the new checklist radio buttons in optimized checkout.

Context:

We changed the checklist from:
image

to:
light-before

To make it more obvious that it is a radio buttons list.

Because of that, we need to include some (s)CSS in cornerstone to match the different theme designs.

Tickets / Documentation

https://jira.bigcommerce.com/browse/CHECKOUT-2461

Screenshots (if appropriate)

Before After
Light light-before light-after
Bold bold-before bold-after
Warm warm-before warm-after

@bigcommerce/checkout @bigcommerce/stencil-team

@icatalina
Copy link
Contributor Author

@davidchin

@icatalina icatalina force-pushed the CHECKOUT-2461 branch 2 times, most recently from beae8e1 to 7c41a31 Compare September 22, 2017 07:24
Copy link
Contributor

@davidchin davidchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidchin
Copy link
Contributor

Oh by the way, there are two minor SassLint errors. Please fix them before merging. :)

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Style optimized checkout new checklist radio buttons [#dada](https://yadayada)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And update the link here please :)

Copy link
Contributor Author

@icatalina icatalina Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many screenshots, I forgot about it 😂

@icatalina
Copy link
Contributor Author

Sorted! 🙂

@icatalina icatalina merged commit 36cd7b3 into bigcommerce:master Sep 25, 2017
@icatalina icatalina deleted the CHECKOUT-2461 branch September 25, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants