Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STENCIL-3105 - Lazy load carousel images #1090

Merged
merged 1 commit into from
Oct 6, 2017
Merged

STENCIL-3105 - Lazy load carousel images #1090

merged 1 commit into from
Oct 6, 2017

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Sep 29, 2017 •
edited

What?

  • Lazy-loads the carousel images.

Tickets / Documentation

Before / After

BEFORE

AFTER

cc @bigcommerce/stencil-team

junedkazi
junedkazi reviewed Sep 29, 2017
View reviewed changes
Copy link
Contributor

@junedkazi junedkazi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is templates/components/common/icons/icon-defs.html ? what icons does it hold ? How is is related to this PR ?

@mjschock
Copy link
Contributor Author

mjschock commented Oct 3, 2017

@junedkazi - it's used to create an svg sprite. see <div class="icons-svg-sprite">{{> components/common/icons/icon-defs }}</div> in base.html for example. i imagine i have a slightly different version of the svgstore grunt task on my machine, causing the diff. i checked out the version from master over it

@mjschock mjschock changed the title STENCIL-3105 - Lazy load carousel images [DO NOT MERGE] STENCIL-3105 - Lazy load carousel images Oct 3, 2017
@mjschock mjschock changed the title [DO NOT MERGE] STENCIL-3105 - Lazy load carousel images STENCIL-3105 - Lazy load carousel images Oct 6, 2017
bookernath
bookernath approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 tested in Chrome and mobile Chrome that the intended effect (deferring loading of images) works correctly. Also tested general function of carousel in IE, Edge, FF, and Safari via browserstack.

@mjschock mjschock merged commit 13532c7 into bigcommerce:master Oct 6, 2017
@mjschock mjschock deleted the STENCIL-3105 branch October 6, 2017 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

@bookernath bookernath bookernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjschock @junedkazi @bookernath