Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-2383 Make cornerstone theme editor menu items to be easier to use #1091

Merged
merged 3 commits into from
Oct 7, 2017
Merged

CP-2383 Make cornerstone theme editor menu items to be easier to use #1091

merged 3 commits into from
Oct 7, 2017

Conversation

deepa2083
Copy link

@deepa2083 deepa2083 commented Oct 3, 2017

Revamping the cornerstone theme editor menu options so it is easier to use.
Attaching the new bundle here for testing.
This will cause test failures and I have another PR that fixes the failures

@bigcommerce/cp-dt @mcampa @bigcommerce/stencil-team @bc-ranji
New bundle here:
Cornerstone-1.9.3.zip

Testing screenshots:
Before the change (existing)
screen shot 2017-10-05 at 12 16 06 pm
screen shot 2017-10-05 at 12 15 56 pm

After update:
screen shot 2017-10-05 at 12 17 39 pm
screen shot 2017-10-05 at 12 17 25 pm

@deepa2083 deepa2083 changed the title DO NOT MERGE: Make cornerstone theme editor menu items to be easier to use DO NOT MERGE OR REVIEW: Make cornerstone theme editor menu items to be easier to use Oct 3, 2017
@mcampa
Copy link
Contributor

mcampa commented Oct 3, 2017

Can you please add the spaces back?
no need to removed the spaces and makes the PR easier to review.

@deepa2083 deepa2083 changed the title DO NOT MERGE OR REVIEW: Make cornerstone theme editor menu items to be easier to use CP-2383 Make cornerstone theme editor menu items to be easier to use Oct 5, 2017
@deepa2083
Copy link
Author

@mcampa - this id - container-border-global-color-dark has been removed. Please advice if this is ok.
looks like it is not used in code.

@mcampa
Copy link
Contributor

mcampa commented Oct 5, 2017

I'm not sure if that is good or bad, that config value is used here

$container-border-global-color-dark: stencilColor("container-border-global-color-dark");

Remember, every field removed from the schema file will prevent customers from changing the configuration value in Theme Editor.

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. Can you add a changelog entry. Also I would like to see a 💚 on it before we merge this one

@bc-ranji
Copy link
Contributor

bc-ranji commented Oct 7, 2017

💚

@deepa2083 deepa2083 merged commit c758e6d into bigcommerce:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants