STENCIL-2497: Makes carousel links functional in IE and Edge. #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristycarpenter
force-pushed
the
STENCIL-2497
branch
from
35c8248
to
6bd0f45
Compare
PascalZajac
force-pushed
the
STENCIL-2497
branch
from
6bd0f45
to
1b748bc
Compare
|
Autotagging @bigcommerce/stencil-team @davidchin |
|
💚 . This fix looks good. Tested on IE 10/11/Edge. Saw the difference between W7 IE10, W8.1 IE11, and W10 Edge 16. The issue has actually been fixed by Edge 16, but Edge 15 still exhibits the old pre-fix behavior. |
|
Thanks a lot for the help @Ubersmake 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows carousel slide links to work in IE and Edge.
Tickets / Documentation
Screenshots (if appropriate)
Before and after video: https://www.screencast.com/t/mlb6Nd3h
Links still work in Chrome, Firefox, and Safari too. Button links also still functional.