STRF-3496: Create year option in date picker if earliest year equals …#1125
Merged
PascalZajac merged 3 commits intobigcommerce:masterfrom Dec 8, 2017
Merged
STRF-3496: Create year option in date picker if earliest year equals …#1125PascalZajac merged 3 commits intobigcommerce:masterfrom
PascalZajac merged 3 commits intobigcommerce:masterfrom
Conversation
|
Autotagging @bigcommerce/stencil-team @davidchin |
PascalZajac
reviewed
Nov 28, 2017
Contributor
PascalZajac
left a comment
PascalZajac
left a comment
There was a problem hiding this comment.
I would probably structure this a bit differently for the sake of improving the UX - either by pre-selecting the only option (by adding the selected attribute), or by changing the field entirely, for example making it hidden unless the user actually needs to pick a choice.
Contributor
Author
|
Updated to auto-select the year if only 1 year is available in the date picker. |
PascalZajac
approved these changes
Dec 5, 2017
Contributor
PascalZajac
left a comment
PascalZajac
left a comment
There was a problem hiding this comment.
LGTM. You need to update the README with a fix note.
Contributor
|
@bdav87 can you add an entry into the changelog file. See https://github.com/bigcommerce/cornerstone/pull/1131/files as an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When the date picker product option has a date restriction within one year, the year options do no populate on the product page, preventing a shopper from adding the item to the cart if the option is required.
This fix creates an option for the year if the earliest_year and latest_year are the same.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-3496
Screenshots (if appropriate)
Before:
After:
