STRF-4158 - Fix Bold Featured Products Clickability #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
suggested changes
Dec 4, 2017
config.json
Outdated
| @@ -357,7 +357,6 @@ | |||
| }, | |||
| "settings": { | |||
| "homepage_featured_products_count": 6, | |||
| "homepage_featured_products_column_count": 3, | |||
There was a problem hiding this comment.
I am not sure I understand how does this break click ability. As a developer I should be able to override the setting in each variation over the default. It should not break the theme.
There was a problem hiding this comment.
@junedkazi you're right, the underlying issue was introduced with #948. i've reverted that change and this one fixes both issues.
|
Autotagging @bigcommerce/stencil-team @davidchin |
|
@junedkazi ♻️ - i'm just fixing the bug here now. i created a separate ticket to address why those properties exist only for Bold themes. |
junedkazi
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
config.jsonoverodehomepage_featured_products_column_countfor Bold themes, causing the clickabilty to break.Tickets / Documentation
ping @bigcommerce/stencil-team